-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated WindowSpy for AHK v2 #9
Conversation
Why did you delete WindowSpy.v1.ahk? I'm guessing that was unintentional. |
My bad. I thought this was a separate repo for v2. I'll put it back. |
All of the release scripts still run on v1, and of course, I use the same scripts to release different versions of AutoHotkey. I put "v1" in the name of the file because I intended for there eventually to be both versions present at once. Actually, the whole installer\source folder will probably need to be duplicated since v2 will have its own installer written in v2. (I'll probably continue using the v1 installer for v1 releases, but include some code to make it play nice with any previously installed v2/multi-version installer.) |
I would prefer not to include the removal and restoration of the v1 file in the commit history. Also, your last commit seems to not have any purpose, as it only removes a newline character which was present at the end of the original file. I would use However, it seems that |
Ok, I'll work on removing those. I use Git for windows, not the Github editor, so I can do the command line stuff. |
Did that work? it seems to have removed erroneous commits. |
* removed redundant code * removed unneeded comment code
Let me know if this works. I tried on the command line but I didn't actually see a list of commits (error message stated there was no tracking information). When I ran the rebase command again specifying the branch, it didn't seem to list anything except the rebase that was about to happen. Sorry, and am a bit of a noob on git stuff. EDIT: I can replicate what I did and go back further (I think). |
Good catch, thanks. |
Eh, sorry that I deleted the comment I was not sure about it and started to doubt about if it was a problem. |
Heh actually, the returned dimensions were wrong for W/H, so it worked out. EDIT: The H/W was permanently set to the window client width given how I queried the values. |
Looks fine, although I might leave this open until I've worked out what I need to change to integrate the separate v2 installer into the release process. Amusingly, the email I received about the force push just said:
|
I'm fine with that. I don't want to mess with it too much more. As long as it is to your liking for the project. |
I figure some minor updates were in order to address the change for |
* labeled "Client" and "Screen" lines for "Control under Mouse" and "Active Window" edit boxes * reformatted strings to show multiple lines with "." concatenator * Finally replaced GetClientSize() with WinGetClientPos() * removed old functions
ca704bb
to
286dc98
Compare
Update Window Spy for AHK v2
... Should be ready now.